Bug 140840 - Implement system fonts FontDescription caching at RenderTheme level
Summary: Implement system fonts FontDescription caching at RenderTheme level
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 140577
  Show dependency tree / graph
 
Reported: 2015-01-23 15:06 PST by Chris Dumez
Modified: 2015-01-23 17:41 PST (History)
3 users (show)

See Also:

Attachments
Patch (34.68 KB, patch)
2015-01-23 15:25 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (34.68 KB, patch)
2015-01-23 15:40 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (34.68 KB, patch)
2015-01-23 16:54 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-23 15:06:19 PST 
Implement system fonts FontDescription caching at RenderTheme level instead of duplicating the logic in its subclasses for each platform. This reduces duplication and reduces the amount of platform-specific code. This will also make the refactoring at Bug 140577 a lot easier.
Comment 1 Chris Dumez 2015-01-23 15:25:05 PST 
Created attachment 245253 [details]
Patch
Comment 2 Chris Dumez 2015-01-23 15:40:09 PST 
Created attachment 245255 [details]
Patch
Comment 3 Andreas Kling 2015-01-23 16:34:16 PST 
Comment on attachment 245255 [details]
Patch

r=me
Comment 4 Chris Dumez 2015-01-23 16:54:39 PST 
Created attachment 245261 [details]
Patch
Comment 5 WebKit Commit Bot 2015-01-23 17:41:35 PST 
Comment on attachment 245261 [details]
Patch

Clearing flags on attachment: 245261

Committed r179050: <http://trac.webkit.org/changeset/179050>
Comment 6 WebKit Commit Bot 2015-01-23 17:41:39 PST 
All reviewed patches have been landed.  Closing bug.