RESOLVED FIXED140825
[Mac][EME] Support ClearKey encryption with AES128-encrypted HLS 
https://bugs.webkit.org/show_bug.cgi?id=140825
Summary [Mac][EME] Support ClearKey encryption with AES128-encrypted HLS
Jer Noble
Reported 2015-01-23 09:05:28 PST
[Mac][EME] Support ClearKey encryption with AES128-encrypted HLS
Attachments
Patch (1.03 MB, patch)
2015-01-23 09:57 PST, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (1.03 MB, patch)
2015-01-23 13:23 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing - w/32-bit build fix (1.03 MB, patch)
2015-01-24 10:01 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-01-23 09:06:41 PST
<rdar://problem/19578900>
Jer Noble
Comment 2 2015-01-23 09:57:26 PST
Created attachment 245233 [details] Patch
Eric Carlson
Comment 3 2015-01-23 10:35:26 PST
Comment on attachment 245233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245233&action=review > Source/WebCore/Modules/encryptedmedia/CDMSessionClearKey.cpp:128 > + if (!keysArray.get(i, keyDictionary) || keyDictionary.isUndefinedOrNull()) > + continue; It is probably worth adding logging in these failure cases. > Source/WebCore/Modules/encryptedmedia/CDMSessionClearKey.h:48 > + virtual RefPtr<ArrayBuffer> cachedKeyForKeyID(const String&) override; Can't this and all of the related methods in other classes be declared "const"?
Jer Noble
Comment 4 2015-01-23 13:23:00 PST
Created attachment 245243 [details] Patch for landing
WebKit Commit Bot
Comment 5 2015-01-23 18:20:35 PST
Comment on attachment 245243 [details] Patch for landing Clearing flags on attachment: 245243 Committed r179051: <http://trac.webkit.org/changeset/179051>
Tim Horton
Comment 6 2015-01-23 18:55:38 PST
This broke the 32-bit Mac build.
Jer Noble
Comment 7 2015-01-24 10:01:56 PST
Created attachment 245286 [details] Patch for landing - w/32-bit build fix
WebKit Commit Bot
Comment 8 2015-02-04 15:27:23 PST
Comment on attachment 245286 [details] Patch for landing - w/32-bit build fix Clearing flags on attachment: 245286 Committed r179641: <http://trac.webkit.org/changeset/179641>
Note You need to log in before you can comment on or make changes to this bug.