Bug 140820 - Hang CSSFontSelector off Document instead of StyleResolver.
Summary: Hang CSSFontSelector off Document instead of StyleResolver.
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2015-01-23 00:43 PST by Andreas Kling
Modified: 2015-01-23 10:44 PST (History)
3 users (show)

See Also:

Patch (22.49 KB, patch)
2015-01-23 01:02 PST, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff
Patch for landing (23.15 KB, patch)
2015-01-23 09:59 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-01-23 00:43:28 PST
Move the CSSFontSelector from StyleResolver to Document. This is the first step
towards making the CSSFontSelector be able to survive full style recalculations.
Comment 1 Andreas Kling 2015-01-23 01:02:36 PST
Created attachment 245216 [details]
Comment 2 WebKit Commit Bot 2015-01-23 01:05:29 PST
Attachment 245216 [details] did not pass style-queue:

ERROR: Source/WebCore/dom/Document.cpp:45:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 16 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2015-01-23 09:30:52 PST
Comment on attachment 245216 [details]

I suspect you could remove StyleResolver.h include from some of these places too.
Comment 4 Andreas Kling 2015-01-23 09:59:20 PST
Created attachment 245234 [details]
Patch for landing
Comment 5 Andreas Kling 2015-01-23 10:44:33 PST
Committed r179012: <http://trac.webkit.org/changeset/179012>