Bug 140800 – [GTK] Scrollbars look bad with GTK+ 3.16

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Created attachment 245181 [details]
Screenshot: upstream scrollbars are half this wide and only appear on mouseover

GTK+ has started using overlay scrollbars (at least with the default Adwaita theme). Our scrollbars look out of place, and are too wide.

[Michael Catanzaro]

I think the cross-platform code already supports overlay scrollbars. Does not look simple to hook up, though.

[Carlos Garcia Campos]

Even if we don't use the overlay scrollbars, the scrollbars should look good, something has changed in adwaita once again that broke our theming code.

[Carlos Garcia Campos]

Created attachment 249028 [details]
Patch

[Sergio Villar Senin]

Comment on attachment 249028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249028&action=review

r+ with a nit

I guess we haven't detected it in the bots because they don't have 3.16. It's unfortunate to have to depend on dogfeeding to detect this kind of regressions.

> Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:281
> +static void adjustRectAccoringToMargin(GtkStyleContext* context, GtkStateFlags state, IntRect& rect)

According. Fix also Changelogs

Also perhaps adjustScrollbarRectToMargin?

[Carlos Garcia Campos]

(In reply to comment #4)
> Comment on attachment 249028 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249028&action=review
> 
> r+ with a nit

Thanks for the review.

> I guess we haven't detected it in the bots because they don't have 3.16.
> It's unfortunate to have to depend on dogfeeding to detect this kind of
> regressions.
> 
> > Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:281
> > +static void adjustRectAccoringToMargin(GtkStyleContext* context, GtkStateFlags state, IntRect& rect)
> 
> According. Fix also Changelogs

Oops.

> Also perhaps adjustScrollbarRectToMargin?

The method is more generic than that, it's used for scrollbars, but has nothing to do with scrollbars.

[Carlos Garcia Campos]

Committed r181744: <http://trac.webkit.org/changeset/181744>