Bug 140789 - Simple line layout: Reset LineState when starting a new line.
Summary: Simple line layout: Reset LineState when starting a new line.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-22 14:38 PST by zalan
Modified: 2015-01-22 15:42 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.00 KB, patch)
2015-01-22 15:15 PST, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-01-22 14:38:54 PST 
To be more explicit about what data we need to transfer from the previous line.
Comment 1 zalan 2015-01-22 15:15:02 PST 
Created attachment 245170 [details]
Patch
Comment 2 Antti Koivisto 2015-01-22 15:19:07 PST 
Comment on attachment 245170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245170&action=review

> Source/WebCore/rendering/SimpleLineLayout.cpp:362
> +static void initializeNewLine(LineState& lineState, const RenderBlockFlow& flow, const FlowContents& flowContents, unsigned lineStartRunIndex)

You could return the new line instead of mutating the argument.
Comment 3 zalan 2015-01-22 15:42:41 PST 
Committed r178964: <http://trac.webkit.org/changeset/178964>