Bug 140781 - Web Inspector: Don't disable BasicBlockAnnotator on click events inside CodeMirror, but instead on drag events
Summary: Web Inspector: Don't disable BasicBlockAnnotator on click events inside CodeM...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-22 13:28 PST by Saam Barati
Modified: 2015-01-30 13:29 PST (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-01-22 13:28:35 PST 
Clicks happen too often to completely disable the BasicBlockAnnotator on each click. Currently, this
provides a sub par user experience. Instead, it should be disabled on drag events.
Comment 1 Radar WebKit Bug Importer 2015-01-22 13:28:49 PST 
<rdar://problem/19568455>
Comment 2 Saam Barati 2015-01-30 13:29:34 PST 
fixed in:
https://bugs.webkit.org/show_bug.cgi?id=140987

Turns out we don't need to disable on drag events either since switching to the new style for showing unexecuted code ranges.