Bug 140780 - [Win] No plugin content on some sites.
Summary: [Win] No plugin content on some sites.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-22 13:25 PST by peavo
Modified: 2015-01-22 23:34 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.55 KB, patch)
2015-01-22 13:52 PST, peavo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-01-22 13:25:38 PST 
This seems to be caused by ScriptController::createScriptInstanceForWidget() always returning null.
Comment 1 peavo 2015-01-22 13:52:55 PST 
Created attachment 245159 [details]
Patch
Comment 2 Brent Fulgham 2015-01-22 15:10:37 PST 
This may be fallout from our recent refactoring to move Plugins out of WebCore and into the WebKit library.

I've currently got the Plugin tests skipped while I work through the whole set of failures. I will take a look at this soon, but maybe you will get to it sooner! :-)
Comment 3 WebKit Commit Bot 2015-01-22 16:18:32 PST 
Comment on attachment 245159 [details]
Patch

Clearing flags on attachment: 245159

Committed r178968: <http://trac.webkit.org/changeset/178968>
Comment 4 WebKit Commit Bot 2015-01-22 16:18:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 peavo 2015-01-22 23:34:44 PST 
(In reply to comment #2)
> This may be fallout from our recent refactoring to move Plugins out of
> WebCore and into the WebKit library.
>  
> I've currently got the Plugin tests skipped while I work through the whole
> set of failures. I will take a look at this soon, but maybe you will get to
> it sooner! :-)

Thanks for reviewing! It's great that you're looking into the tests, I just noticed this during everyday browsing :)