Bug 140773 – [Win] Expose missing editing features through WebView interface

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Brent Fulgham]

Several layout tests fail because the Windows port is not exposing necessary editing support features.

[Radar WebKit Bug Importer]

<rdar://problem/19565421>

[Brent Fulgham]

Created attachment 245172 [details]
Patch

[WebKit Commit Bot]

Attachment 245172 [details] did not pass style-queue:


ERROR: Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/DumpRenderTree/win/EditingDelegate.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Comment on attachment 245172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245172&action=review

> Source/WebKit/win/DOMCoreClasses.cpp:2
> + * Copyright (C) 2006, 2007, 2009, 2014 Apple Inc.  All rights reserved.

Check your wall calendar.

> Tools/DumpRenderTree/win/EditingDelegate.cpp:175
> +    static const char* insertactionstring[] = {

insertActionString maybe?

> Tools/DumpRenderTree/win/EditingDelegate.cpp:212
> +    static const char* affinitystring[] = {

Ditto

[Brent Fulgham]

(In reply to comment #4)
> Comment on attachment 245172 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245172&action=review
> 
> > Source/WebKit/win/DOMCoreClasses.cpp:2
> > + * Copyright (C) 2006, 2007, 2009, 2014 Apple Inc.  All rights reserved.
> 
> Check your wall calendar.
> 

Doh!

> > Tools/DumpRenderTree/win/EditingDelegate.cpp:175
> > +    static const char* insertactionstring[] = {
> 
> insertActionString maybe?

Sure!

> > Tools/DumpRenderTree/win/EditingDelegate.cpp:212
> > +    static const char* affinitystring[] = {

OK!
> Ditto

[Brent Fulgham]

Committed r178965: <http://trac.webkit.org/changeset/178965>