Bug 140761 - PropertyListNode::emitNode duplicates the code to put a constant property
Summary: PropertyListNode::emitNode duplicates the code to put a constant property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 140491
  Show dependency tree / graph
 
Reported: 2015-01-21 23:05 PST by Ryosuke Niwa
Modified: 2015-01-22 10:07 PST (History)
4 users (show)

See Also:

Attachments
Fixes the bug (4.31 KB, patch)
2015-01-21 23:08 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Added back the missing continue (4.29 KB, patch)
2015-01-21 23:26 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-01-21 23:05:05 PST 
PropertyListNode::emitNode shouldn't duplicate the code to put a constant property.
Comment 1 Ryosuke Niwa 2015-01-21 23:08:27 PST 
Created attachment 245123 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2015-01-21 23:26:19 PST 
Created attachment 245124 [details]
Added back the missing continue
Comment 3 Geoffrey Garen 2015-01-22 08:49:52 PST 
Comment on attachment 245124 [details]
Added back the missing continue

r=me
Comment 4 Ryosuke Niwa 2015-01-22 10:02:44 PST 
Comment on attachment 245124 [details]
Added back the missing continue

Thanks for the review!
Comment 5 WebKit Commit Bot 2015-01-22 10:07:15 PST 
Comment on attachment 245124 [details]
Added back the missing continue

Clearing flags on attachment: 245124

Committed r178918: <http://trac.webkit.org/changeset/178918>
Comment 6 WebKit Commit Bot 2015-01-22 10:07:29 PST 
All reviewed patches have been landed.  Closing bug.