Bug 140754 - Consolidate out arguments of parseFunctionInfo into a struct
Summary: Consolidate out arguments of parseFunctionInfo into a struct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 140491
  Show dependency tree / graph
 
Reported: 2015-01-21 19:54 PST by Ryosuke Niwa
Modified: 2015-01-21 22:39 PST (History)
7 users (show)

See Also:

Attachments
Refactoring (31.32 KB, patch)
2015-01-21 20:15 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-01-21 19:54:04 PST 
parseFunctionInfo has a whole bunch of out arguments. We should put them all into a struct for better code readability.
Comment 1 Ryosuke Niwa 2015-01-21 20:15:09 PST 
Created attachment 245111 [details]
Refactoring
Comment 2 Ryosuke Niwa 2015-01-21 20:55:19 PST 
I don't think EWS failures are related to this patch.
Comment 3 Ryosuke Niwa 2015-01-21 21:56:33 PST 
Thanks for the review!
Comment 4 WebKit Commit Bot 2015-01-21 22:39:28 PST 
Comment on attachment 245111 [details]
Refactoring

Clearing flags on attachment: 245111

Committed r178888: <http://trac.webkit.org/changeset/178888>
Comment 5 WebKit Commit Bot 2015-01-21 22:39:32 PST 
All reviewed patches have been landed.  Closing bug.