Bug 140742 - [iOS] Many compositing tests fail in DumpRenderTree due to contentsOpaque difference
Summary: [iOS] Many compositing tests fail in DumpRenderTree due to contentsOpaque dif...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad iOS 8.1
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-21 14:27 PST by Daniel Bates
Modified: 2015-01-21 15:42 PST (History)
3 users (show)

See Also:

Attachments
Patch (9.99 KB, patch)
2015-01-21 14:31 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-01-21 14:27:09 PST 
Many compositing tests fail in DumpRenderTree due to contentsOpaque difference because the main frame's RenderView layer is always transparent in iOS WebKit1.
Comment 1 Daniel Bates 2015-01-21 14:31:21 PST 
Created attachment 245092 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-01-21 14:41:23 PST 
Comment on attachment 245092 [details]
Patch

Why don't we just not dump contentsOpaque for this layer.
Comment 3 Daniel Bates 2015-01-21 14:59:18 PST 
(In reply to comment #2)
> Comment on attachment 245092 [details]
> Patch
> 
> Why don't we just not dump contentsOpaque for this layer.

Simon and I talked about this on IRC today (01/21). We felt there is value in dumping the contentsOpaque for the main frame's RenderView layer for tiled drawing scrolling tests (e.g. tests under LayoutTests/platform/mac-wk2/tiled-drawing/scrolling).
Comment 4 Daniel Bates 2015-01-21 15:42:09 PST 
Comment on attachment 245092 [details]
Patch

Clearing flags on attachment: 245092

Committed r178868: <http://trac.webkit.org/changeset/178868>
Comment 5 Daniel Bates 2015-01-21 15:42:12 PST 
All reviewed patches have been landed.  Closing bug.