Bug 140735 - [TexMap] Avoid unnecessary TransformationMatrix copies in GraphicsLayerTransform
Summary: [TexMap] Avoid unnecessary TransformationMatrix copies in GraphicsLayerTransform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-21 12:00 PST by Zan Dobersek
Modified: 2015-02-01 03:34 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.26 KB, patch)
2015-01-21 12:10 PST, Zan Dobersek 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2015-01-21 12:00:37 PST 
[TexMap] Avoid unnecessary TransformationMatrix copies in GraphicsLayerTransform
Comment 1 Zan Dobersek 2015-01-21 12:10:53 PST 
Created attachment 245075 [details]
Patch
Comment 2 Chris Dumez 2015-01-27 20:41:22 PST 
Comment on attachment 245075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245075&action=review

r=me % nits.

> Source/WebCore/platform/graphics/GraphicsLayerTransform.h:39
> +    const TransformationMatrix& combined();

Why isn't this method const?

> Source/WebCore/platform/graphics/GraphicsLayerTransform.h:40
> +    const TransformationMatrix& combinedForChildren();

Ditto.
Comment 3 Zan Dobersek 2015-02-01 02:04:12 PST 
Comment on attachment 245075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245075&action=review

>> Source/WebCore/platform/graphics/GraphicsLayerTransform.h:40
>> +    const TransformationMatrix& combinedForChildren();
> 
> Ditto.

This calls combineTransformsForChildren(), which modifies m_childrenDirty and m_combinedForChildren.

I prefer combinedForChildren() and combineTransformsForChildren() to be const and have m_childrenDirty and m_combinedForChildren changed to mutable.
Comment 4 Zan Dobersek 2015-02-01 03:34:48 PST 
Landed in r179462.
http://trac.webkit.org/changeset/179462