Bug 140727 - Web Inspector: Don't allow the BasicBlockAnnotator to highlight a section if it's only a closing brace
Summary: Web Inspector: Don't allow the BasicBlockAnnotator to highlight a section if ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-21 09:02 PST by Saam Barati
Modified: 2015-01-21 14:51 PST (History)
8 users (show)

See Also:

Attachments
the patch (3.17 KB, patch)
2015-01-21 13:57 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-01-21 09:02:04 PST 
There are times when a textual basic block will only consist of blank space, this
can happen in the following situation:

if (foo) {
    bar();
    return; // Or: throw, break, continue.
} // This closing brace will be highlighted, because the code after the return statement is unreachable.

This is a common enough case that the BasicBlockAnnotator should special case it.
Comment 1 Radar WebKit Bug Importer 2015-01-21 09:02:25 PST 
<rdar://problem/19548864>
Comment 2 Saam Barati 2015-01-21 13:57:14 PST 
Created attachment 245083 [details]
the patch
Comment 3 WebKit Commit Bot 2015-01-21 14:51:43 PST 
Comment on attachment 245083 [details]
the patch

Clearing flags on attachment: 245083

Committed r178863: <http://trac.webkit.org/changeset/178863>
Comment 4 WebKit Commit Bot 2015-01-21 14:51:46 PST 
All reviewed patches have been landed.  Closing bug.