Bug 140726 - [Win] eventSender does not support scalePageBy
Summary: [Win] eventSender does not support scalePageBy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-21 08:54 PST by Brent Fulgham
Modified: 2015-01-21 10:59 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.14 KB, patch)
2015-01-21 10:28 PST, Brent Fulgham 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-01-21 08:54:31 PST 
We need to implement zoomPageIn and zoomPageOut in DRT to support tests:

fast/dom/zoom-scroll-page-test.html
Comment 1 Brent Fulgham 2015-01-21 09:27:38 PST 
Actually, the missing function is 'scalePageBy', which causes the test to fail before we even hit the (existing) zoomPageIn/zoomPageOut.
Comment 2 Radar WebKit Bug Importer 2015-01-21 10:20:20 PST 
<rdar://problem/19549865>
Comment 3 Brent Fulgham 2015-01-21 10:28:58 PST 
Created attachment 245068 [details]
Patch
Comment 4 Brent Fulgham 2015-01-21 10:31:18 PST 
Comment on attachment 245068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245068&action=review

> Tools/DumpRenderTree/win/EventSender.cpp:763
> +

I should be checking that argumentCount >= 3 so we don't crash.
Comment 5 Brent Fulgham 2015-01-21 10:37:40 PST 
These tests also pass now:

fast/repaint/fixed-in-page-scale.html
fast/repaint/fixed-right-bottom-in-page-scale.html
fast/repaint/fixed-right-in-page-scale.html
Comment 6 Brent Fulgham 2015-01-21 10:53:11 PST 
Also:

fast/css/sticky/sticky-top-zoomed.html
compositing/tiling/tile-cache-zoomed.html:
Comment 7 Brent Fulgham 2015-01-21 10:59:01 PST 
Committed r178849: <http://trac.webkit.org/changeset/178849>