Bug 140720 - [CSS Grid Layout] Skip items spanning flex tracks when sizing content based tracks
Summary: [CSS Grid Layout] Skip items spanning flex tracks when sizing content based t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on: 140615
Blocks: 60731
  Show dependency treegraph
 
Reported: 2015-01-21 00:47 PST by Sergio Villar Senin
Modified: 2015-01-22 00:56 PST (History)
0 users

See Also:


Attachments
Patch (11.67 KB, patch)
2015-01-21 10:41 PST, Sergio Villar Senin
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2015-01-21 00:47:10 PST
The specs mention the following in the second step of the algorithm described in "Resolve Intrinsic Track Sizes section":

"2- Increase sizes to accommodate spanning items: Next, consider the items with a span of 2 that do not span a track with a flexible sizing function"

We are using those items so we must detect and keep them away for further actions.
Comment 1 Sergio Villar Senin 2015-01-21 10:41:57 PST
Created attachment 245069 [details]
Patch
Comment 2 Dave Hyatt 2015-01-21 10:43:02 PST
Comment on attachment 245069 [details]
Patch

r=me, but didn't apply, so watch layout tests.
Comment 3 Sergio Villar Senin 2015-01-22 00:56:16 PST
Committed r178895: <http://trac.webkit.org/changeset/178895>