Bug 140712 - Move w3c/canvas/resources/ common resources to w3c/resources/
Summary: Move w3c/canvas/resources/ common resources to w3c/resources/
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
Depends on:
Reported: 2015-01-20 19:49 PST by Said Abou-Hallawa
Modified: 2015-01-21 11:35 PST (History)
1 user (show)

See Also:

Patch (421.58 KB, patch)
2015-01-20 19:56 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2015-01-20 19:49:47 PST
The w3c test suites has the directory images/ for common resources.  It has also the directory common/ for common scripts. When the canvas tests were ported to WebKit, the common/ directory was copied as is but the images/ directory was copied to w3c/canvas/resources/. The problem is some of the scripts under the directory common/ reference the common images. The path in the script file like '../resources/background.png' which does not exist. The result is some of the tests are failing because some of images are missing.

The cleanest way to fix this issue is to inherit the w3c directory structure and to move the common resources from w3c/canvas/resources/ to w3c/resources/. And of course all the paths to the common resources from the w3c/canvas and w3c/common should be ../resources/<file name> instead of resources/<file name>
Comment 1 Said Abou-Hallawa 2015-01-20 19:56:19 PST
Created attachment 245043 [details]
Comment 2 Alexey Proskuryakov 2015-01-20 23:58:04 PST
Comment on attachment 245043 [details]

Comment 3 WebKit Commit Bot 2015-01-21 11:35:10 PST
Comment on attachment 245043 [details]

Clearing flags on attachment: 245043

Committed r178854: <http://trac.webkit.org/changeset/178854>
Comment 4 WebKit Commit Bot 2015-01-21 11:35:12 PST
All reviewed patches have been landed.  Closing bug.