Bug 140709 - Web Inspector: Clean up InjectedScriptSource.js
Summary: Web Inspector: Clean up InjectedScriptSource.js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-01-20 18:17 PST by Joseph Pecoraro
Modified: 2015-01-20 20:22 PST (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (24.86 KB, patch)
2015-01-20 18:31 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-01-20 18:17:13 PST
* SUMMARY
Clean up InjectedScriptSource.js.

1. Remove unused/stale ClosureCompiler comments
2. Simple formatting / style / logic cleanup
3. Port some fixes from Blink where they make sense
Comment 1 Radar WebKit Bug Importer 2015-01-20 18:17:24 PST
<rdar://problem/19542943>
Comment 2 Joseph Pecoraro 2015-01-20 18:31:51 PST
Created attachment 245039 [details]
[PATCH] Proposed Fix

All tests stayed the same. Did some basic testing and everything worked as expected. Including verifying the fixes.
Comment 3 WebKit Commit Bot 2015-01-20 20:22:21 PST
Comment on attachment 245039 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 245039

Committed r178796: <http://trac.webkit.org/changeset/178796>
Comment 4 WebKit Commit Bot 2015-01-20 20:22:25 PST
All reviewed patches have been landed.  Closing bug.