Bug 140704 - [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
Summary: [iOS] Update configure-xcode-for-ios-development to copy missing headers to i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
: 140702 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-01-20 16:54 PST by David Kilzer (:ddkilzer)
Modified: 2015-01-22 20:07 PST (History)
4 users (show)

See Also:


Attachments
Patch v1 (4.76 KB, patch)
2015-01-20 17:03 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v2 (4.82 KB, patch)
2015-01-21 02:47 PST, David Kilzer (:ddkilzer)
dbates: review+
ddkilzer: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2015-01-20 16:54:59 PST
The iphoneos SDK is missing the <objc/objc-runtime.h> and <objc/Protocol.h> headers, so they need to be copied from the iphonesimulator SDK to make WebKit build with the external iOS SDK.

This is another step in making the ios-ews queue build.
Comment 1 David Kilzer (:ddkilzer) 2015-01-20 17:03:29 PST
Created attachment 245035 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2015-01-21 02:30:14 PST
*** Bug 140702 has been marked as a duplicate of this bug. ***
Comment 3 David Kilzer (:ddkilzer) 2015-01-21 02:36:36 PST
Comment on attachment 245035 [details]
Patch v1

Will post a new patch to include fix for Bug 140702.
Comment 4 David Kilzer (:ddkilzer) 2015-01-21 02:47:33 PST
Created attachment 245056 [details]
Patch v2
Comment 5 David Kilzer (:ddkilzer) 2015-01-21 02:47:57 PST
*** Bug 140702 has been marked as a duplicate of this bug. ***
Comment 6 Daniel Bates 2015-01-21 11:04:40 PST
Comment on attachment 245056 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=245056&action=review

> Tools/Scripts/configure-xcode-for-ios-development:85
> +        die "Could not copy $iphonesimulatorSDKPath to $iphoneosSDKPath: $!" if (exitStatus($?) != 0);

I take it you feel it that improves the readability of the code to explicitly check that the exit status is not zero.
Comment 7 David Kilzer (:ddkilzer) 2015-01-21 11:49:39 PST
(In reply to comment #6)
> Comment on attachment 245056 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245056&action=review
> 
> > Tools/Scripts/configure-xcode-for-ios-development:85
> > +        die "Could not copy $iphonesimulatorSDKPath to $iphoneosSDKPath: $!" if (exitStatus($?) != 0);
> 
> I take it you feel it that improves the readability of the code to
> explicitly check that the exit status is not zero.

I don't feel strongly either way.  Does most code use `!exitStatus($?)` instead of `exitStatus($?) != 0`?
Comment 8 David Kilzer (:ddkilzer) 2015-01-21 11:56:10 PST
(In reply to comment #7)
> (In reply to comment #6)
> > Comment on attachment 245056 [details]
> > Patch v2
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=245056&action=review
> > 
> > > Tools/Scripts/configure-xcode-for-ios-development:85
> > > +        die "Could not copy $iphonesimulatorSDKPath to $iphoneosSDKPath: $!" if (exitStatus($?) != 0);
> > 
> > I take it you feel it that improves the readability of the code to
> > explicitly check that the exit status is not zero.
> 
> I don't feel strongly either way.  Does most code use `!exitStatus($?)`
> instead of `exitStatus($?) != 0`?

And by `!exitStatus($?)` I meant `exitStatus($?)`.  Will fix before landing.
Comment 9 David Kilzer (:ddkilzer) 2015-01-21 15:22:24 PST
Committed r178866: <http://trac.webkit.org/changeset/178866>
Comment 10 David Kilzer (:ddkilzer) 2015-01-21 15:24:02 PST
(In reply to comment #9)
> Committed r178866: <http://trac.webkit.org/changeset/178866>

Note that I added all the headers that were needed to successfully build for the iphoneos SDK at r178719.
Comment 11 David Kilzer (:ddkilzer) 2015-01-22 20:07:11 PST
(In reply to comment #10)
> (In reply to comment #9)
> > Committed r178866: <http://trac.webkit.org/changeset/178866>
> 
> Note that I added all the headers that were needed to successfully build for
> the iphoneos SDK at r178719.

Follow-up fix for a runtime issue:

Committed r178979: <http://trac.webkit.org/changeset/178979>