Bug 140700 - Identity in DFG not allocating new register.
Summary: Identity in DFG not allocating new register.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matthew Mirman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-20 15:40 PST by Matthew Mirman
Modified: 2015-01-20 17:12 PST (History)
4 users (show)

See Also:

Attachments
A testcase that fails due to this bug. (464 bytes, application/x-javascript)
2015-01-20 15:40 PST, Matthew Mirman 		no flags Details
Made Identity in the DFG allocate a new temp register (1.92 KB, patch)
2015-01-20 15:47 PST, Matthew Mirman 		fpizlo: review-
fpizlo: commit-queue-
Details | Formatted Diff | Diff
Made Identity in the DFG allocate a new temp register (2.84 KB, patch)
2015-01-20 16:02 PST, Matthew Mirman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Mirman 2015-01-20 15:40:40 PST 
Created attachment 245029 [details]
A testcase that fails due to this bug.

Patch forthcoming. 

<rdar://problem/19339106>
Comment 1 Matthew Mirman 2015-01-20 15:47:46 PST 
Created attachment 245030 [details]
Made Identity in the DFG allocate a new temp register
Comment 2 Filip Pizlo 2015-01-20 15:49:19 PST 
Comment on attachment 245030 [details]
Made Identity in the DFG allocate a new temp register

This should either reenable the test that discovered this, or write a new test.  It would probably be sufficient to just reenable the skipped test.  This patch should include that.
Comment 3 Matthew Mirman 2015-01-20 16:02:53 PST 
Created attachment 245032 [details]
Made Identity in the DFG allocate a new temp register

Enabled that test case.
Comment 4 WebKit Commit Bot 2015-01-20 17:12:49 PST 
Comment on attachment 245032 [details]
Made Identity in the DFG allocate a new temp register

Clearing flags on attachment: 245032

Committed r178788: <http://trac.webkit.org/changeset/178788>
Comment 5 WebKit Commit Bot 2015-01-20 17:12:54 PST 
All reviewed patches have been landed.  Closing bug.