Bug 140698 - Add and hook up APINavigationClient
Summary: Add and hook up APINavigationClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-20 15:23 PST by Tim Horton
Modified: 2015-01-30 17:29 PST (History)
4 users (show)

See Also:

Attachments
Patch (67.41 KB, patch)
2015-01-20 15:24 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Preliminary Part 2 (32.80 KB, patch)
2015-01-23 19:12 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (62.43 KB, patch)
2015-01-29 14:52 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (63.25 KB, patch)
2015-01-30 16:50 PST, Tim Horton 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-01-20 15:23:58 PST 
Add and hook up APINavigationClient
Comment 1 Tim Horton 2015-01-20 15:24:21 PST 
Created attachment 245026 [details]
Patch
Comment 2 Sam Weinig 2015-01-20 18:06:24 PST 
Comment on attachment 245026 [details]
Patch

Looking good. I think we need to merge the NavigationState conditions and change the NavigationClient names to match the WKNavigationDelegate names before we land this.
Comment 3 Tim Horton 2015-01-23 19:12:54 PST 
Created attachment 245271 [details]
Preliminary Part 2

Started on Sam's part 2, but haven't finished yet. Here's a WIP.
Comment 4 Tim Horton 2015-01-29 14:52:42 PST 
Created attachment 245654 [details]
Patch
Comment 5 Tim Horton 2015-01-30 16:25:50 PST 
Comment on attachment 245654 [details]
Patch

Found some things that need fixing.
Comment 6 Tim Horton 2015-01-30 16:50:43 PST 
Created attachment 245760 [details]
Patch
Comment 7 Tim Horton 2015-01-30 17:29:23 PST 
http://trac.webkit.org/changeset/179430