Bug 140696 - Web Inspector: Expected gutter highlight when selecting console input line, just like output line
Summary: Web Inspector: Expected gutter highlight when selecting console input line, j...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-20 15:07 PST by Joseph Pecoraro
Modified: 2015-01-22 15:05 PST (History)
10 users (show)

See Also:

Attachments
[IMAGE] Selection Issue (41.72 KB, image/png)
2015-01-20 15:07 PST, Joseph Pecoraro 		no flags Details
Patch (1.37 KB, patch)
2015-01-22 00:27 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Animated GIF with the patch applied (265.24 KB, image/gif)
2015-01-22 00:28 PST, Nikita Vasilyev 		no flags Details
Archive of layout-test-results from ews103 for mac-mavericks (658.87 KB, application/zip)
2015-01-22 01:22 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-01-20 15:07:40 PST 
Created attachment 245024 [details]
[IMAGE] Selection Issue

* SUMMARY
Expected gutter highlight when selecting console input line, just like output line. See attached images.

* STEPS TO REPRODUCE
1. Open inspector
2. js> 1+1
3. Select input and output messages in console
  => expected same gutter highlight
Comment 1 Radar WebKit Bug Importer 2015-01-20 15:08:05 PST 
<rdar://problem/19539518>
Comment 2 Nikita Vasilyev 2015-01-22 00:27:45 PST 
Created attachment 245128 [details]
Patch
Comment 3 Nikita Vasilyev 2015-01-22 00:28:41 PST 
Created attachment 245129 [details]
Animated GIF with the patch applied
Comment 4 Build Bot 2015-01-22 01:22:27 PST 
Comment on attachment 245128 [details]
Patch

Attachment 245128 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4749603769417728

New failing tests:
compositing/geometry/video-opacity-overlay.html
Comment 5 Build Bot 2015-01-22 01:22:30 PST 
Created attachment 245130 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 WebKit Commit Bot 2015-01-22 02:23:32 PST 
Comment on attachment 245128 [details]
Patch

Clearing flags on attachment: 245128

Committed r178911: <http://trac.webkit.org/changeset/178911>
Comment 7 WebKit Commit Bot 2015-01-22 02:23:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Joseph Pecoraro 2015-01-22 14:34:01 PST 
Comment on attachment 245128 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245128&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.css:76
> +.console-messages:focus .console-item.selected .console-user-command::after,
>  .console-messages:focus .console-item.selected .console-message::after {

These could both use :matches. But I'll leave that up to you.

    .console-messages:focus .console-item.selected :matches(.console-user-command, .console-message)::after { ... }
Comment 9 Timothy Hatcher 2015-01-22 14:38:26 PST 
Comment on attachment 245128 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245128&action=review

>> Source/WebInspectorUI/UserInterface/Views/LogContentView.css:76
>>  .console-messages:focus .console-item.selected .console-message::after {
> 
> These could both use :matches. But I'll leave that up to you.
> 
>     .console-messages:focus .console-item.selected :matches(.console-user-command, .console-message)::after { ... }

I agree. I feel we should use :matches() more.
Comment 10 Nikita Vasilyev 2015-01-22 15:05:56 PST 
Will do next time. I keep forgetting that I can use some many latest CSS and ECMAScript features.