Bug 140686 - Drop width / height shorthands code from StylePropertyShorthand.*
Summary: Drop width / height shorthands code from StylePropertyShorthand.*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-20 11:10 PST by Chris Dumez
Modified: 2015-01-20 12:54 PST (History)
4 users (show)

See Also:

Attachments
WIP Patch (2.18 KB, patch)
2015-01-20 11:11 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.46 KB, patch)
2015-01-20 11:56 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-20 11:10:40 PST 
Drop width / height shorthands code from StylePropertyShorthand.*

width / height are not shorthands for min-width/max-width and min-height/max-height. Also, only matchingCustomShorthandsForLonghand() handles those shorthands, while the reverse method (indexOfShorthandForLonghand) does not.
Comment 1 Chris Dumez 2015-01-20 11:11:25 PST 
Created attachment 245001 [details]
WIP Patch
Comment 2 Alexis Menard (darktears) 2015-01-20 11:53:02 PST 
Not that it counts me but r+
Comment 3 Chris Dumez 2015-01-20 11:56:26 PST 
Created attachment 245007 [details]
Patch
Comment 4 WebKit Commit Bot 2015-01-20 12:54:17 PST 
Comment on attachment 245007 [details]
Patch

Clearing flags on attachment: 245007

Committed r178746: <http://trac.webkit.org/changeset/178746>
Comment 5 WebKit Commit Bot 2015-01-20 12:54:21 PST 
All reviewed patches have been landed.  Closing bug.