Bug 140671 - [gstreamer] Fix expression result unused warning in GRefPtrGStreamer.cpp
Summary: [gstreamer] Fix expression result unused warning in GRefPtrGStreamer.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-20 03:48 PST by Csaba Osztrogonác
Modified: 2015-01-20 08:24 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.27 KB, patch)
2015-01-20 03:50 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (1.34 KB, patch)
2015-01-20 07:28 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-01-20 03:48:50 PST
warning:
../../Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:251:9: warning: expression result unused [-Wunused-value]
        (GstToc*)gst_mini_object_ref(((GstMiniObject*)(ptr)));
        ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Comment 1 Csaba Osztrogonác 2015-01-20 03:50:17 PST
Created attachment 244982 [details]
Patch
Comment 2 Philippe Normand 2015-01-20 06:53:44 PST
Is this the only fix possible? Don't we have some macro in WTF about this?
Comment 3 Csaba Osztrogonác 2015-01-20 07:00:51 PST
(In reply to comment #2)
> Is this the only fix possible? Don't we have some macro in WTF about this?
I haven't found.
Comment 4 Philippe Normand 2015-01-20 07:07:36 PST
Ok not sure it'd be worth adding anyway :)
Comment 5 Philippe Normand 2015-01-20 07:14:20 PST
Comment on attachment 244982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244982&action=review

> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:251
> -        gst_toc_ref(ptr);
> +        (void)gst_toc_ref(ptr);

Actually we could return the result value here, return gst_toc_ref(ptr);
Comment 6 Csaba Osztrogonác 2015-01-20 07:28:01 PST
Created attachment 244991 [details]
Patch
Comment 7 WebKit Commit Bot 2015-01-20 08:24:06 PST
Comment on attachment 244991 [details]
Patch

Clearing flags on attachment: 244991

Committed r178711: <http://trac.webkit.org/changeset/178711>
Comment 8 WebKit Commit Bot 2015-01-20 08:24:11 PST
All reviewed patches have been landed.  Closing bug.