Bug 140654 - Resolve the epsilon transitions for each state upfront instead of dynamically
Summary: Resolve the epsilon transitions for each state upfront instead of dynamically
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-19 18:09 PST by Benjamin Poulain
Modified: 2015-01-20 12:43 PST (History)
1 user (show)

See Also:

Attachments
Patch (9.12 KB, patch)
2015-01-19 18:12 PST, Benjamin Poulain 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-01-19 18:09:23 PST 
Resolve the epsilon transitions for each state upfront instead of dynamically
Comment 1 Benjamin Poulain 2015-01-19 18:12:06 PST 
Created attachment 244947 [details]
Patch
Comment 2 Andreas Kling 2015-01-20 01:31:27 PST 
Comment on attachment 244947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244947&action=review

r=me

> Source/WebCore/contentextensions/NFAToDFA.cpp:84
> +        if (nfaNodeClosures[nodeId].size()) {

I softly prefer !isEmpty() over size() here.
Comment 3 Benjamin Poulain 2015-01-20 12:43:27 PST 
Committed r178739: <http://trac.webkit.org/changeset/178739>