fast/hidpi/image-srcset-change-dynamically-from-js-2x.html sometimes fails on WK2 bots. It sometimes fails, other times has output showing that it reloaded more than once. The test uses a pretty complicated helper script that has multiple load event handlers that compete with testRunner.setBackingScaleFactor() completion.
Created attachment 244941 [details] proposed fix
Comment on attachment 244941 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=244941&action=review > LayoutTests/ChangeLog:8 > + Speculative fix, streamline resources/srcset-helper.js and remove races. I could actually reproduce the flakiness with run-webkit-tests fast/hidpi/image-srcset-change-dynamically-from-js-2x.html --no-retry -2 --repeat 1000 -f
Comment on attachment 244941 [details] proposed fix Attachment 244941 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4856970032971776 New failing tests: svg/css/svg-resource-fragment-identifier-img-src.html fast/dom/HTMLImageElement/sizes/image-sizes-2x.html
Created attachment 244943 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 244941 [details] proposed fix Attachment 244941 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6596122952859648 New failing tests: svg/css/svg-resource-fragment-identifier-img-src.html fast/dom/HTMLImageElement/sizes/image-sizes-2x.html
Created attachment 244956 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 244970 [details] a more complete fix Turns out that: 1. The script was used outside its directory, so more tests needed to be updated. 2. We had two copies of the script, and thus an opportunity to unify them. I think that this fixes another flaky test, which was wrongfully skipped before.
Comment on attachment 244970 [details] a more complete fix Clearing flags on attachment: 244970 Committed r178721: <http://trac.webkit.org/changeset/178721>
All reviewed patches have been landed. Closing bug.
*** Bug 134923 has been marked as a duplicate of this bug. ***