Bug 14064 – fill property is reported as type SVGColor

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Rob Buis]

When using getPresentationAttribute to get the fill css property, asking for its type gives us SVGColor, it should be SVGPaint.

[Rob Buis]

Created attachment 14929 [details]
First attempt

Discussed with Sam, probably worth having this at least for the testcase.
Cheers,

Rob.

[Sam Weinig]

Comment on attachment 14929 [details]
First attempt

I assume this is for the experimental branch as this won't apply on ToT (kjs_css.cpp has changed).  We should however also land the layout test and the fix (in JSCSSValueCustom.cpp) in ToT as well. r=me

[Darin Adler]

svg/custom/dynamic-viewBox.svg is mentioned in the ChangeLog, but I don't see it in the patch.

[Darin Adler]

ChangeLog has the wrong title for the bug.

[Darin Adler]

Cant land the layout test in TOT because getPresentationAttribute is not yet in TOT.

[Darin Adler]

Created attachment 15572 [details]
patch for trunk, but no good because test won't work

[Rob Buis]

Hi Darin,

(In reply to comment #6)
> Created an attachment (id=15572) [edit]
> patch for trunk, but no good because test won't work

I see the dilemma. I guess there are 2 options:
1) fix this when merging experimental branch back into ToT
2)  apply the getPresentationAttribute patch to ToT

To make the merging lighter, maybe 2 makes that a bit easier. If you agree with that, I can do 2) if you want as I also did the getPresentationAttribute patch.
Cheers,

Rob.

[Rob Buis]

This was adapted in rebased fb in r25842 by olliej. For now we close it, have to see later how this makes it into trunk.
Cheers,

Rob.