Bug 14064 - fill property is reported as type SVGColor
Summary: fill property is reported as type SVGColor
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2007-06-10 19:30 PDT by Rob Buis
Modified: 2007-10-03 08:34 PDT (History)
0 users

See Also:

First attempt (20.09 KB, patch)
2007-06-10 23:12 PDT, Rob Buis
sam: review+
Details | Formatted Diff | Diff
patch for trunk, but no good because test won't work (21.24 KB, patch)
2007-07-18 20:38 PDT, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2007-06-10 19:30:50 PDT
When using getPresentationAttribute to get the fill css property, asking for its type gives us SVGColor, it should be SVGPaint.
Comment 1 Rob Buis 2007-06-10 23:12:13 PDT
Created attachment 14929 [details]
First attempt

Discussed with Sam, probably worth having this at least for the testcase.

Comment 2 Sam Weinig 2007-06-10 23:22:19 PDT
Comment on attachment 14929 [details]
First attempt

I assume this is for the experimental branch as this won't apply on ToT (kjs_css.cpp has changed).  We should however also land the layout test and the fix (in JSCSSValueCustom.cpp) in ToT as well. r=me
Comment 3 Darin Adler 2007-07-18 20:14:45 PDT
svg/custom/dynamic-viewBox.svg is mentioned in the ChangeLog, but I don't see it in the patch.
Comment 4 Darin Adler 2007-07-18 20:15:02 PDT
ChangeLog has the wrong title for the bug.
Comment 5 Darin Adler 2007-07-18 20:37:32 PDT
Cant land the layout test in TOT because getPresentationAttribute is not yet in TOT.
Comment 6 Darin Adler 2007-07-18 20:38:57 PDT
Created attachment 15572 [details]
patch for trunk, but no good because test won't work
Comment 7 Rob Buis 2007-07-18 23:35:18 PDT
Hi Darin,

(In reply to comment #6)
> Created an attachment (id=15572) [edit]
> patch for trunk, but no good because test won't work

I see the dilemma. I guess there are 2 options:
1) fix this when merging experimental branch back into ToT
2)  apply the getPresentationAttribute patch to ToT

To make the merging lighter, maybe 2 makes that a bit easier. If you agree with that, I can do 2) if you want as I also did the getPresentationAttribute patch.

Comment 8 Rob Buis 2007-10-03 08:34:14 PDT
This was adapted in rebased fb in r25842 by olliej. For now we close it, have to see later how this makes it into trunk.