Bug 140635 - DocumentLoader::applicationCacheHost() should return a reference.
Summary: DocumentLoader::applicationCacheHost() should return a reference.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-19 12:20 PST by Andreas Kling
Modified: 2017-04-18 20:23 PDT (History)
4 users (show)

See Also:


Attachments
Patch (31.52 KB, patch)
2015-01-19 12:21 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (1.48 MB, application/zip)
2015-01-19 13:29 PST, Build Bot
no flags Details
Archive of layout-test-results from ews100 for mac-mavericks (909.14 KB, application/zip)
2015-01-19 17:26 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-01-19 12:20:08 PST
There's always an ApplicationCacheHost on the DocumentLoader. applicationCacheHost() should return a reference.
Comment 1 Andreas Kling 2015-01-19 12:21:39 PST
Created attachment 244917 [details]
Patch
Comment 2 Build Bot 2015-01-19 13:29:11 PST
Comment on attachment 244917 [details]
Patch

Attachment 244917 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5840873489170432

New failing tests:
http/tests/appcache/different-origin-manifest.html
http/tests/appcache/document-write-html-element.html
http/tests/appcache/cyrillic-uri.html
http/tests/appcache/online-whitelist.html
http/tests/appcache/insert-html-element-with-manifest-2.html
http/tests/appcache/crash-when-navigating-away-then-back.html
http/tests/appcache/navigating-away-while-cache-attempt-in-progress.html
http/tests/appcache/max-size.html
http/tests/appcache/origin-quota.html
http/tests/appcache/top-frame-1.html
http/tests/appcache/whitelist-wildcard.html
http/tests/appcache/disabled.html
http/tests/appcache/main-resource-fallback-for-network-error-crash.html
http/tests/appcache/reload.html
http/tests/appcache/history-test.html
http/tests/appcache/main-resource-redirect.html
http/tests/appcache/fail-on-update.html
http/tests/appcache/top-frame-3.html
http/tests/appcache/resource-redirect-2.html
http/tests/appcache/wrong-signature-2.html
http/tests/appcache/manifest-parsing.html
http/tests/appcache/origin-quota-continued-download-multiple-manifests.html
http/tests/appcache/origins-with-appcache.html
http/tests/appcache/update-cache.html
http/tests/appcache/offline-access.html
http/tests/appcache/foreign-fallback.html
http/tests/security/cross-origin-appcache.html
http/tests/appcache/local-content.html
http/tests/appcache/fail-on-update-2.html
Comment 3 Build Bot 2015-01-19 13:29:14 PST
Created attachment 244923 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-01-19 17:26:29 PST
Comment on attachment 244917 [details]
Patch

Attachment 244917 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5559445622882304

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2015-01-19 17:26:32 PST
Created attachment 244942 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 Csaba Osztrogonác 2015-09-14 11:06:49 PDT
Comment on attachment 244917 [details]
Patch

Cleared Anders Carlsson's review+ from obsolete attachment 244917 [details] so that this bug does not appear in http://webkit.org/pending-commit.