Bug 140632 – [iOS][WK2] Redraw find-in-page indicator on rotation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Martin Hock]

Redraw find-in-page indicator on rotation

[Martin Hock]

Created attachment 244915 [details]
patch

[Tim Horton]

Comment on attachment 244915 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244915&action=review

> Source/WebKit2/WebProcess/WebPage/FindController.cpp:374
> +    if (m_isShowingFindIndicator) {

this should be an early return.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3481
> +    m_findController.redraw();

Might this be helpful on Mac too? Does it do the right thing there? (I'm guessing not, so this is probably best for now)

> Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:99
> +        m_webPage->zoomToRect(matchRect, m_webPage->minimumPageScaleFactor(), std::min(m_webPage->maximumPageScaleFactor(), maximumFindIndicatorZoom));

Why this change? If the highlighted text moves out of view after a layout, wouldn't we want to zoom to it?

[Martin Hock]

(In reply to comment #2)
> > Source/WebKit2/WebProcess/WebPage/FindController.cpp:374
> > +    if (m_isShowingFindIndicator) {
> 
> this should be an early return.

Will do.

> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3481
> > +    m_findController.redraw();
> 
> Might this be helpful on Mac too? Does it do the right thing there? (I'm
> guessing not, so this is probably best for now)

The changes don't seem to be necessary on Mac.

> > Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:99
> > +        m_webPage->zoomToRect(matchRect, m_webPage->minimumPageScaleFactor(), std::min(m_webPage->maximumPageScaleFactor(), maximumFindIndicatorZoom));
> 
> Why this change? If the highlighted text moves out of view after a layout,
> wouldn't we want to zoom to it?

I don't think we'd like the view to move constantly if text is animated. Furthermore, the user panning could trigger this code and we wouldn't like that to move the view around, either.

[Martin Hock]

Committed r178755: <http://trac.webkit.org/changeset/178755>