WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
140623
[iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
https://bugs.webkit.org/show_bug.cgi?id=140623
Summary
[iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
David Kilzer (:ddkilzer)
Reported
2015-01-19 10:26:12 PST
When starting the ios-ews queue, the following command is run to kick off a build: Tools/Scripts/build-webkit --release --sdk=iphoneos ARCHS=armv7 However, buildXCodeProject() changes the SDK from 'iphoneos' to 'iphoneos.internal', causing an error: xcodebuild: error: SDK "iphoneos.internal" cannot be located. The fix is to stop buildXCodeProject() from assuming that building for the device always means using the internal SDK.
Attachments
Patch v1
(2.10 KB, patch)
2015-01-19 10:33 PST
,
David Kilzer (:ddkilzer)
dbates
: review+
ap
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2015-01-19 10:33:30 PST
Created
attachment 244907
[details]
Patch v1
Daniel Bates
Comment 2
2015-01-19 10:35:36 PST
Comment on
attachment 244907
[details]
Patch v1 View in context:
https://bugs.webkit.org/attachment.cgi?id=244907&action=review
> Tools/Scripts/webkitdirs.pm:438 > + $xcodeSDK ||= $hasInternalSDK ? 'iphoneos.internal' : 'iphoneos';
Nit: We should take this opportunity to use double quotes instead of single quotes to be more consistent with the majority of the Perl code.
David Kilzer (:ddkilzer)
Comment 3
2015-01-19 10:36:21 PST
This also makes --device prefer the "iphoneos.internal" SDK if it is installed, else it falls back to the "iphoneos" SDK.
Alexey Proskuryakov
Comment 4
2015-01-19 10:39:17 PST
Comment on
attachment 244907
[details]
Patch v1 r=me too. I think that this patch needs to fix build-webkit --help output: $ build-webkit --help ... --device Use the current iphoneos.internal SDK (iOS only) Also, perhaps EWS should use --device now, not --sdk=iphoneos. Not a big deal though.
Daniel Bates
Comment 5
2015-01-19 10:40:14 PST
Comment on
attachment 244907
[details]
Patch v1 View in context:
https://bugs.webkit.org/attachment.cgi?id=244907&action=review
> Tools/Scripts/webkitdirs.pm:1643 >
Nit: We can write the simplify the if condition to isIOSWebKit().
David Kilzer (:ddkilzer)
Comment 6
2015-01-19 11:05:08 PST
Committed
r178656
: <
http://trac.webkit.org/changeset/178656
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug