Bug 140617 - [GTK] Add an option to create WebKitWebView snapshots with transparent background
Summary: [GTK] Add an option to create WebKitWebView snapshots with transparent backgr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-01-19 05:37 PST by Carlos Garcia Campos
Modified: 2015-01-20 00:29 PST (History)
5 users (show)

See Also:


Attachments
Patch (7.10 KB, patch)
2015-01-19 05:44 PST, Carlos Garcia Campos
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-01-19 05:37:28 PST
Add WEBKIT_SNAPSHOT_OPTIONS_TRANSPARENT_BACKGROUND flag to not fill with white the background before rendering the snapshot.
Comment 1 Carlos Garcia Campos 2015-01-19 05:44:11 PST
Created attachment 244899 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-19 05:46:25 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2015-01-19 08:28:59 PST
Comment on attachment 244899 [details]
Patch

Looks good to me. Needs one more reviewer though.
Comment 4 Gustavo Noronha (kov) 2015-01-19 14:40:55 PST
Comment on attachment 244899 [details]
Patch

Yep!
Comment 5 Carlos Garcia Campos 2015-01-20 00:29:27 PST
Committed r178700: <http://trac.webkit.org/changeset/178700>