Bug 140601 – Merge API::ProcessPoolConfiguration and _WKProcessPoolConfiguration

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Merge API::ProcessPoolConfiguration and _WKProcessPoolConfiguration

[Sam Weinig]

Created attachment 244871 [details]
Patch

[Sam Weinig]

Created attachment 244872 [details]
Patch

[Anders Carlsson]

Comment on attachment 244872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244872&action=review

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:376
>      static WebProcessPool* processPool;
>      if (!processPool) {
> -        WebProcessPoolConfiguration configuration;
> -        WebProcessPool::applyPlatformSpecificConfigurationDefaults(configuration);
> -        
> -        processPool = (WebProcessPool::create(WTF::move(configuration))).leakRef();
> -        processPool->setProcessModel(ProcessModelMultipleSecondaryProcesses);
> +        auto configuration = API::ProcessPoolConfiguration::createWithLegacyOptions();
> +        configuration->setProcessModel(ProcessModelMultipleSecondaryProcesses);
> +
> +        processPool = &(WebProcessPool::create(configuration.get())).leakRef();
>      }

I think you should initialize this with a lambda:

static WebProcessPool& processPool = []{
    ...
    return WebProcessPool::create(configuration.get())).leakRef();
}();

[Sam Weinig]

Committed r178685: <http://trac.webkit.org/changeset/178685>

[Csaba Osztrogonác]

(In reply to comment #4)
> Committed r178685: <http://trac.webkit.org/changeset/178685>

It broke the Apple Mountain Lion and EFL bots:
EFL bot - before: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/19081
EFL bot - after: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/19082
Apple Mountain Lion bot - before: https://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/builds/23657
Apple Mountain Lion bot - after: https://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/builds/23658

Could you possibly fix this regression?

[Sam Weinig]

Attempt to fix tests in r178720.