Bug 140567 - Web Inspector: Do not request Scope Chain lists if section is collapsed (mainly Global Variables)
Summary: Web Inspector: Do not request Scope Chain lists if section is collapsed (main...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 143097 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-01-16 14:47 PST by Joseph Pecoraro
Modified: 2017-03-16 14:43 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (9.01 KB, patch)
2016-08-15 16:02 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-01-16 14:47:47 PST
* SUMMARY
Do not request Scope Chain lists if section is collapsed (mainly Global Variables).

The Global Variables Scope Chain section (and message to populate it) is HUGE. Its sort shows constructors before properties so I normally don't care and I collapse the section. Even if it is collapsed we still update it every pause (so every step, etc). We should avoid this work if we don't need to do it.
Comment 1 Radar WebKit Bug Importer 2015-01-16 14:48:02 PST
<rdar://problem/19504745>
Comment 2 Joseph Pecoraro 2016-08-15 16:02:35 PDT
Created attachment 286108 [details]
[PATCH] Proposed Fix

This should make stepping through code a little faster if users haven't expanded the "Global Variables" section, which defaults to collapsed. On many pages that is a very large message, and it takes non-trivial amount of processing in InjectedScriptSource to build.
Comment 3 WebKit Commit Bot 2016-08-16 10:27:53 PDT
Comment on attachment 286108 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 286108

Committed r204513: <http://trac.webkit.org/changeset/204513>
Comment 4 WebKit Commit Bot 2016-08-16 10:27:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Joseph Pecoraro 2017-03-16 14:43:09 PDT
*** Bug 143097 has been marked as a duplicate of this bug. ***