Bug 140559 – Add a basic configuration object for WKView

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Add a basic configuration object for WKView

[Sam Weinig]

Created attachment 244788 [details]
Patch

[WebKit Commit Bot]

Attachment 244788 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/APIPageConfiguration.cpp:50:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/API/APIPageConfiguration.cpp:60:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Created attachment 244810 [details]
Patch

[Anders Carlsson]

Comment on attachment 244810 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244810&action=review

> Source/WebKit2/UIProcess/API/APIPageConfiguration.h:45
> +    static PassRefPtr<PageConfiguration> create()

Ref.

> Source/WebKit2/UIProcess/API/C/WKUserContentControllerRef.cpp:44
> +WKArrayRef WKUserContentControllerGetUserScripts(WKUserContentControllerRef userContentControllerRef)

This should probably copy the user scripts.

> Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.h:60
> +    static RefPtr<WebUserContentControllerProxy> create()

Ref!

> Tools/TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:44
> +    ASSERT_NULL(WKPageConfigurationGetContext(configuration.get()));
> +    ASSERT_NULL(WKPageConfigurationGetUserContentController(configuration.get()));
> +    ASSERT_NULL(WKPageConfigurationGetPageGroup(configuration.get()));
> +    ASSERT_NULL(WKPageConfigurationGetPreferences(configuration.get()));
> +    ASSERT_NULL(WKPageConfigurationGetRelatedPage(configuration.get()));

Shouldn't these be instantiated when you ask for them?

[Sam Weinig]

(In reply to comment #4)
> Comment on attachment 244810 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244810&action=review
> 
> > Source/WebKit2/UIProcess/API/APIPageConfiguration.h:45
> > +    static PassRefPtr<PageConfiguration> create()
> 
> Ref.
> 

Will change.

> > Source/WebKit2/UIProcess/API/C/WKUserContentControllerRef.cpp:44
> > +WKArrayRef WKUserContentControllerGetUserScripts(WKUserContentControllerRef userContentControllerRef)
> 
> This should probably copy the user scripts.

Ok.

> 
> > Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.h:60
> > +    static RefPtr<WebUserContentControllerProxy> create()
> 
> Ref!

Will change.

> 
> > Tools/TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:44
> > +    ASSERT_NULL(WKPageConfigurationGetContext(configuration.get()));
> > +    ASSERT_NULL(WKPageConfigurationGetUserContentController(configuration.get()));
> > +    ASSERT_NULL(WKPageConfigurationGetPageGroup(configuration.get()));
> > +    ASSERT_NULL(WKPageConfigurationGetPreferences(configuration.get()));
> > +    ASSERT_NULL(WKPageConfigurationGetRelatedPage(configuration.get()));
> 
> Shouldn't these be instantiated when you ask for them?

I want that to be the case eventually, but I need to do more refactoring a bit lower down to make it clean.

[Sam Weinig]

Created attachment 244825 [details]
Patch

[Sam Weinig]

Committed r178618: <http://trac.webkit.org/changeset/178618>

[David Kilzer (:ddkilzer)]

(In reply to comment #7)
> Committed r178618: <http://trac.webkit.org/changeset/178618>

Looks like you could have used an iOS EWS bot, Sam.  :(

Attempted iOS build fix:
Committed r178625: <http://trac.webkit.org/changeset/178625>