WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
14053
Autogenerate JS binding for Rect
https://bugs.webkit.org/show_bug.cgi?id=14053
Summary
Autogenerate JS binding for Rect
Sam Weinig
Reported
2007-06-09 18:22:27 PDT
Patch forthcoming, includes cleanup.
Attachments
patch
(30.50 KB, patch)
2007-06-09 18:31 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
updated patch
(55.47 KB, patch)
2007-06-15 10:08 PDT
,
Sam Weinig
darin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2007-06-09 18:31:04 PDT
Created
attachment 14919
[details]
patch
Darin Adler
Comment 2
2007-06-14 20:47:27 PDT
Comment on
attachment 14919
[details]
patch Why are there so many changes here that are unrelated to DOMRect? Could we have the cleanup in a separate patch? Can't we just rename RectImpl to WebCore::Rect? Why not?
Sam Weinig
Comment 3
2007-06-15 09:48:29 PDT
Comment on
attachment 14919
[details]
patch Thanks for reviewing this Tim, but I am removing the review flag and will post a new patch that renames RectImpl to Rect to be consistent. I will post the patch shortly.
Sam Weinig
Comment 4
2007-06-15 10:08:09 PDT
Created
attachment 15059
[details]
updated patch This updated patch changes RectImpl to Rect and fixes the name conflict in WebKit by using ::Rect for the Rect struct in the global namespace.
Darin Adler
Comment 5
2007-06-15 16:23:00 PDT
Comment on
attachment 15059
[details]
updated patch dom/Attr.idl \ - dom/CharacterData.idl \ dom/CDATASection.idl \ Why? + //rgbColors.remove(rgbColor.handle()); What is it, and why is this commented out? Otherwise, r=me
Sam Weinig
Comment 6
2007-06-15 18:30:03 PDT
(In reply to
comment #5
)
> (From update of
attachment 15059
[details]
[edit]) > dom/Attr.idl \ > - dom/CharacterData.idl \ > dom/CDATASection.idl \ > > Why?
This was just some sorting that went bad, has been fixed.
> + //rgbColors.remove(rgbColor.handle()); > > What is it, and why is this commented out?
Not sure what this was, but it was in the old code commented out so I moved it over to the new stuff. My guess it was an old caching mechanism, but since we are not going to ever resurrect it I have now removed it.
Sam Weinig
Comment 7
2007-06-15 19:00:03 PDT
Landed in
r23557
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug