Bug 14053 – Autogenerate JS binding for Rect

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Sam Weinig]

Patch forthcoming, includes cleanup.

[Sam Weinig]

Created attachment 14919 [details]
patch

[Darin Adler]

Comment on attachment 14919 [details]
patch

Why are there so many changes here that are unrelated to DOMRect? Could we have the cleanup in a separate patch?

Can't we just rename RectImpl to WebCore::Rect? Why not?

[Sam Weinig]

Comment on attachment 14919 [details]
patch

Thanks for reviewing this Tim, but I am removing the review flag and will post a new patch that renames RectImpl to Rect to be consistent.  I will post the patch shortly.

[Sam Weinig]

Created attachment 15059 [details]
updated patch

This updated patch changes RectImpl to Rect and fixes the name conflict in WebKit by using ::Rect for the Rect struct in the global namespace.

[Darin Adler]

Comment on attachment 15059 [details]
updated patch

     dom/Attr.idl \
-    dom/CharacterData.idl \
     dom/CDATASection.idl \

Why?

+    //rgbColors.remove(rgbColor.handle());

What is it, and why is this commented out?

Otherwise, r=me

[Sam Weinig]

(In reply to comment #5)
> (From update of attachment 15059 [details] [edit])
>      dom/Attr.idl \
> -    dom/CharacterData.idl \
>      dom/CDATASection.idl \
> 
> Why?

This was just some sorting that went bad, has been fixed.

> +    //rgbColors.remove(rgbColor.handle());
> 
> What is it, and why is this commented out?

Not sure what this was, but it was in the old code commented out so I moved it over to the new stuff.  My guess it was an old caching mechanism, but since we are not going to ever resurrect it I have now removed it.

[Sam Weinig]

Landed in r23557.