Bug 140529 - [Mac][EME] Crash in CDMSessionMediaSourceAVFObjC::layerDidReceiveError() - NSError not KVO compliant for key NSUnderlyingError.
Summary: [Mac][EME] Crash in CDMSessionMediaSourceAVFObjC::layerDidReceiveError() - NS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-15 16:44 PST by Jer Noble
Modified: 2015-02-07 00:07 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.11 KB, patch)
2015-01-15 16:46 PST, Jer Noble
darin: review+
darin: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (1.79 KB, patch)
2015-01-26 09:26 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-01-15 16:44:40 PST
[Mac][EME] Crash in CDMSessionMediaSourceAVFObjC::layerDidReceiveError() - NSError not KVO compliant for key NSUnderlyingError.
Comment 1 Jer Noble 2015-01-15 16:46:14 PST
Created attachment 244726 [details]
Patch
Comment 2 Darin Adler 2015-01-21 07:59:08 PST
Comment on attachment 244726 [details]
Patch

This has an extra change log entry.

How are we regression-testing this fix?
Comment 3 Jer Noble 2015-01-26 09:24:41 PST
(In reply to comment #2)
> Comment on attachment 244726 [details]
> Patch
> 
> This has an extra change log entry.

Whoops, will fix.

> How are we regression-testing this fix?

We have no idea when or why AVFoundation is firing this type of error (with a code of AVErrorUnknown). Ironically, once we correct this piece and start returning the underlying error, the clients of WebKit's EME API can start reporting what underlying error they're seeing. And we may be able to write a regression or manual test at that point.
Comment 4 Jer Noble 2015-01-26 09:26:48 PST
Created attachment 245354 [details]
Patch for landing
Comment 5 Jer Noble 2015-02-03 12:21:21 PST
<rdar://problem/19491197>
Comment 6 WebKit Commit Bot 2015-02-03 13:06:39 PST
Comment on attachment 245354 [details]
Patch for landing

Clearing flags on attachment: 245354

Committed r179563: <http://trac.webkit.org/changeset/179563>