There's a big switch/if chain in EncodingTraits<NondeterministicInputBase>::decodeValue/encodeValue() that should be converted. This should require some fairly trivial changes to the input code generator to make the TypeCastTraits specializations.
Created attachment 244862 [details] Patch
This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)
Attachment 244862 [details] did not pass style-queue: ERROR: Source/WebCore/replay/SerializationMethods.cpp:169: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 244862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244862&action=review r=me > Source/JavaScriptCore/replay/scripts/tests/expected/generate-input-with-guard.json-TestReplayInputs.h:91 > +#if ENABLE(DUMMY_FEATURE) What is this DUMMY_FEATURE? > Source/WebCore/replay/MemoizedDOMResult.h:155 > + New spaces?
Comment on attachment 244862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244862&action=review >> Source/JavaScriptCore/replay/scripts/tests/expected/generate-input-with-guard.json-TestReplayInputs.h:91 >> +#if ENABLE(DUMMY_FEATURE) > > What is this DUMMY_FEATURE? This test covers generation of ENABLE guards. Useful for inputs related to TOUCH_EVENTS, REQUEST_ANIMATION_FRAME, etc. >> Source/WebCore/replay/MemoizedDOMResult.h:155 >> + > > New spaces? Oops, Xcode :(
Committed r178668: <http://trac.webkit.org/changeset/178668>