Bug 14050 – Text field focus ring overdrawn by button click animation when submitting form with Enter key

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Layout and Rendering

[David Kilzer (:ddkilzer)]

* SUMMARY
The text field focus ring is overdrawn by the button click animation on www.google.com when the Enter key is used to submit the form.

Note that when clicking the button with the mouse, the focus ring on the text field is removed before the button click animation, thus preventing this issue.

* STEPS TO REPRODUCE
1. Launch WebKit/Safari.
2. Go to URL:  http://www.google.com/
3. Focus the text field used for search (via mouse or tab key).
4. Type witty search terms (like "asdf").
5. Hit Enter key.  (DO NOT click the search button with the mouse, or use the tab key to focus the search button.)

* EXPECTED RESULTS
The button click animation should not draw over the text field focus ring.

* ACTUAL RESULTS
The button click animation draws over the text field focus ring.

* REGRESSION
This is not a regression from shipping Safari 2.0.4 (419.3) on Mac OS X 10.4.9 (8P135) as that version behaves the same way.  Tested with a local debug build of WebKit r22080 with the above software.

* NOTES
The correct fix is probably to remove the focus ring from the text field before the button click animation occurs for form submittal.

[David Kilzer (:ddkilzer)]

Created attachment 14915 [details]
Manual test case

[David Kilzer (:ddkilzer)]

Created attachment 14916 [details]
Gratuitous movie showing issue on Google

Not specific to focus rings, a solid outline also gets damaged.

I think this is fixed.

[David Kilzer (:ddkilzer)]

(In reply to comment #4)
> I think this is fixed.

Yes this seems to be fixed now with the latest nightly builds!

[David Kilzer (:ddkilzer)]

Fixed somewhere between r38605 (bug still reproduces) and r38679 (bug is fixed).

I am guessing <http://trac.webkit.org/changeset/38651>, the fix for bug 19623.

[David Kilzer (:ddkilzer)]

(In reply to comment #6)
> Fixed somewhere between r38605 (bug still reproduces) and r38679 (bug is
> fixed).

That was with autospade.  Using bisect-builds, we have:

Fails: r38676  Works: r38683

Thus it was fixed between r38676 and r38679.  Likely fixed by r38678:

http://trac.webkit.org/changeset/38678

(In reply to comment #8)
> (In reply to comment #6)
> > Fixed somewhere between r38605 (bug still reproduces) and r38679 (bug is
> > fixed).
> 
> That was with autospade.  Using bisect-builds, we have:
> 
> Fails: r38676  Works: r38683
> 
> Thus it was fixed between r38676 and r38679.  Likely fixed by r38678:
> 
> http://trac.webkit.org/changeset/38678
> 

Yes. My last comment was wrong.

[David Kilzer (:ddkilzer)]

(In reply to comment #7)
> I am guessing <http://trac.webkit.org/changeset/38651>, the fix for bug 19623.

But you would be wrong.  :)  See Bug 22159 which was fixed in r38678.

[David Kilzer (:ddkilzer)]

*** This bug has been marked as a duplicate of 22159 ***