Bug 140485 – AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

If by focusing an object causes a JS alert to appear, VO will hang, because accessibilitySetValue: never gets a chance to return

To fix this we should perform the setValue operation after a delay so that we can return immediately to VoiceOver

<rdar://problem/19433451>

[chris fleizach]

Created attachment 246236 [details]
patch

[Build Bot]

Comment on attachment 246236 [details]
patch

Attachment 246236 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5645715678167040

New failing tests:
platform/mac/accessibility/setting-attributes-is-asynchronous.html

[Build Bot]

Created attachment 246238 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Anders Carlsson]

Comment on attachment 246236 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246236&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3253
> +    dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 0), dispatch_get_main_queue(), ^{
> +        [self _accessibilitySetValue:value forAttribute:attributeName];
> +    });

I think you can just use dispatch_async here instead of dispatch_after.

[Anders Carlsson]

Comment on attachment 246236 [details]
patch

r=me if you address the comment I had!.

[chris fleizach]

(In reply to comment #5)
> Comment on attachment 246236 [details]
> patch
> 
> r=me if you address the comment I had!.

Thanks! will do

[chris fleizach]

http://trac.webkit.org/changeset/179820