WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
140480
Convert ManualTests/svg-tooltip.svg to a DRT test
https://bugs.webkit.org/show_bug.cgi?id=140480
Summary
Convert ManualTests/svg-tooltip.svg to a DRT test
Said Abou-Hallawa
Reported
2015-01-14 16:42:06 PST
The following tests can be automated using the API internals.toolTipFromElement() ManualTests/svg-tooltip.svg ManualTests/svg-links.svg (probably)
Attachments
Layout Test
(8.42 KB, patch)
2015-02-18 18:46 PST
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
Layout Test
(8.48 KB, patch)
2015-02-18 18:53 PST
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2015-02-18 18:44:44 PST
(In reply to
comment #0
)
> The following tests can be automated using the API > internals.toolTipFromElement()
>
> ManualTests/svg-links.svg (probably)
Notice that ManualTests/svg-links.svg allows a person to test link dragging and we do not have machinery to test this at this time. The lack of such machinery meant that we failed to catch a regression in link dragging support :( (
bug #141597
). I filed
bug #141787
to look into converting ManualTests/svg-links.svg to be a DRT test.
Daniel Bates
Comment 2
2015-02-18 18:46:48 PST
Created
attachment 246870
[details]
Layout Test
Daniel Bates
Comment 3
2015-02-18 18:53:55 PST
Created
attachment 246872
[details]
Layout Test Add missing semicolon and update comment in runTest() to be more descriptive.
Said Abou-Hallawa
Comment 4
2015-02-19 10:06:03 PST
unofficial r=me.
Alex Christensen
Comment 5
2015-02-19 18:50:45 PST
Comment on
attachment 246872
[details]
Layout Test View in context:
https://bugs.webkit.org/attachment.cgi?id=246872&action=review
> LayoutTests/svg/hittest/svg-tooltip-expected.txt:5 > +PASS tooltip for <use id="e4"> is ''.
Why is this blank?
> LayoutTests/svg/hittest/svg-tooltip-expected.txt:8 > +PASS tooltip for <use id="e7"> is ''.
ditto.
WebKit Commit Bot
Comment 6
2015-03-03 14:43:58 PST
Comment on
attachment 246872
[details]
Layout Test Clearing flags on attachment: 246872 Committed
r180957
: <
http://trac.webkit.org/changeset/180957
>
WebKit Commit Bot
Comment 7
2015-03-03 14:44:02 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug