WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
140474
Add a way to collect scrolling performance data (viewport tile coverage) with UI-side compositing
https://bugs.webkit.org/show_bug.cgi?id=140474
Summary
Add a way to collect scrolling performance data (viewport tile coverage) with...
Simon Fraser (smfr)
Reported
2015-01-14 15:52:46 PST
Add a way to collect scrolling performance data (viewport tile coverage) with UI-side compositing
Attachments
Patch
(31.52 KB, patch)
2015-01-14 17:51 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(32.16 KB, patch)
2015-01-16 11:13 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(31.33 KB, patch)
2015-01-16 11:14 PST
,
Simon Fraser (smfr)
thorton
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2015-01-14 17:51:35 PST
Created
attachment 244670
[details]
Patch
Csaba Osztrogonác
Comment 2
2015-01-15 04:03:55 PST
Comment on
attachment 244670
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=244670&action=review
> Source/WebKit2/UIProcess/WebPageProxy.cpp:58 > +#include "RemoteLayerTreeScrollingPerformanceData.h"
Please move this include to the "#if PLATFORM(COCOA)" block _before_ landing not to break the EFL/GTK builds. Thanks.
Simon Fraser (smfr)
Comment 3
2015-01-16 11:13:59 PST
Created
attachment 244774
[details]
Patch
Simon Fraser (smfr)
Comment 4
2015-01-16 11:14:48 PST
Created
attachment 244775
[details]
Patch
Tim Horton
Comment 5
2015-01-16 11:36:06 PST
Comment on
attachment 244775
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=244775&action=review
> Source/WebCore/platform/graphics/ca/TileController.cpp:45 > + return "TileGrid Container Layer";
While this is not perf-critical code, I know there's a better way to make a String from a literal (but I don't know what it is).
> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:849 > +- (WebCore::FloatRect)visibleRectInScreenCoordinates
screen? I see no screen here.
> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:930 > + scrollPerfData->didCommitLayerTree([self visibleRectInScreenCoordinates]);
dot notation?
> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1391 > + scrollPerfData->didScroll([self visibleRectInScreenCoordinates]);
dot notation?
> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2128 > + return nil; > +#else > + return nil; > +#endif
This can be simplified.
> Source/WebKit2/UIProcess/Cocoa/RemoteLayerTreeScrollingPerformanceData.h:45 > + NSArray* data(); // Array of [ time, event type, unfilled pixel count ]
star's on the wrong side
> Source/WebKit2/UIProcess/Cocoa/RemoteLayerTreeScrollingPerformanceData.h:50 > + RemoteLayerTreeDrawingAreaProxy& m_drawingArea;
This interspersion of type declarations and function declarations and members is weird. Can this be sorted?
> Source/WebKit2/UIProcess/Cocoa/RemoteLayerTreeScrollingPerformanceData.mm:78 > + NSMutableArray* dataArray = [NSMutableArray arrayWithCapacity:m_blankPixelCounts.size()];
star's on the wrong side!
> Source/WebKit2/UIProcess/Cocoa/RemoteLayerTreeScrollingPerformanceData.mm:90 > +static CALayer *findTileGridContainerLayer(CALayer *layer)
Should we keep its id instead of using names and crawling the tree?
Simon Fraser (smfr)
Comment 6
2015-01-20 10:41:02 PST
https://trac.webkit.org/r178723
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug