Bug 140461 – Move ClipRects and ClipRectsCache to RenderLayer.cpp.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

where they belong.

[alan]

Created attachment 244632 [details]
Patch

[alan]

Created attachment 244635 [details]
Patch

[Darin Adler]

Comment on attachment 244635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244635&action=review

Patch does not apply.

Besides making these private, could you also move the inlines into RenderLayer.cpp file and consider moving as much of the class definitions as possible into RenderLayer.cpp too? Things only need to be in the header if something in the header uses them.

> Source/WebCore/rendering/RenderLayer.h:685
> +        void reset(const LayoutRect& r);

I suggest omitting the argument name "r".

> Source/WebCore/rendering/RenderLayer.h:1001
> +    ClipRect backgroundClipRectForPosition(const ClipRects& parentRects, EPosition position) const;

I sugget omitting the argument name “position”.

[alan]

Created attachment 244679 [details]
Patch

[alan]

(In reply to comment #3)
> Comment on attachment 244635 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244635&action=review
> 
> Patch does not apply.
The patch has dependency on bug 140457. (it's landed by now)

> 
> Besides making these private, could you also move the inlines into
> RenderLayer.cpp file and consider moving as much of the class definitions as
> possible into RenderLayer.cpp too? Things only need to be in the header if
> something in the header uses them.
Done.

> 
> > Source/WebCore/rendering/RenderLayer.h:685
> > +        void reset(const LayoutRect& r);
> 
> I suggest omitting the argument name "r".
Moved to .cpp

> 
> > Source/WebCore/rendering/RenderLayer.h:1001
> > +    ClipRect backgroundClipRectForPosition(const ClipRects& parentRects, EPosition position) const;
> 
> I sugget omitting the argument name “position”.
Not applicable anymore.

[WebKit Commit Bot]

Comment on attachment 244679 [details]
Patch

Clearing flags on attachment: 244679

Committed r178533: <http://trac.webkit.org/changeset/178533>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.