WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
140461
Move ClipRects and ClipRectsCache to RenderLayer.cpp.
https://bugs.webkit.org/show_bug.cgi?id=140461
Summary
Move ClipRects and ClipRectsCache to RenderLayer.cpp.
zalan
Reported
2015-01-14 13:16:37 PST
where they belong.
Attachments
Patch
(12.60 KB, patch)
2015-01-14 13:20 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(12.62 KB, patch)
2015-01-14 13:51 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(13.67 KB, patch)
2015-01-14 21:20 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2015-01-14 13:20:46 PST
Created
attachment 244632
[details]
Patch
zalan
Comment 2
2015-01-14 13:51:47 PST
Created
attachment 244635
[details]
Patch
Darin Adler
Comment 3
2015-01-14 15:53:32 PST
Comment on
attachment 244635
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=244635&action=review
Patch does not apply. Besides making these private, could you also move the inlines into RenderLayer.cpp file and consider moving as much of the class definitions as possible into RenderLayer.cpp too? Things only need to be in the header if something in the header uses them.
> Source/WebCore/rendering/RenderLayer.h:685 > + void reset(const LayoutRect& r);
I suggest omitting the argument name "r".
> Source/WebCore/rendering/RenderLayer.h:1001 > + ClipRect backgroundClipRectForPosition(const ClipRects& parentRects, EPosition position) const;
I sugget omitting the argument name “position”.
zalan
Comment 4
2015-01-14 21:20:44 PST
Created
attachment 244679
[details]
Patch
zalan
Comment 5
2015-01-14 21:25:52 PST
(In reply to
comment #3
)
> Comment on
attachment 244635
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=244635&action=review
> > Patch does not apply.
The patch has dependency on
bug 140457
. (it's landed by now)
> > Besides making these private, could you also move the inlines into > RenderLayer.cpp file and consider moving as much of the class definitions as > possible into RenderLayer.cpp too? Things only need to be in the header if > something in the header uses them.
Done.
> > > Source/WebCore/rendering/RenderLayer.h:685 > > + void reset(const LayoutRect& r); > > I suggest omitting the argument name "r".
Moved to .cpp
> > > Source/WebCore/rendering/RenderLayer.h:1001 > > + ClipRect backgroundClipRectForPosition(const ClipRects& parentRects, EPosition position) const; > > I sugget omitting the argument name “position”.
Not applicable anymore.
WebKit Commit Bot
Comment 6
2015-01-15 15:13:37 PST
Comment on
attachment 244679
[details]
Patch Clearing flags on attachment: 244679 Committed
r178533
: <
http://trac.webkit.org/changeset/178533
>
WebKit Commit Bot
Comment 7
2015-01-15 15:13:44 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug