Bug 140425 - [Win] Layout Test fast/css/crash-on-custom-cursor-when-loading.html is failing
Summary: [Win] Layout Test fast/css/crash-on-custom-cursor-when-loading.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-13 20:27 PST by Brent Fulgham
Modified: 2015-01-14 10:25 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.64 KB, patch)
2015-01-13 20:30 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-01-13 20:27:41 PST 
The following layout test is failing on Windows.

fast/css/crash-on-custom-cursor-when-loading.html

Probable cause:

Windows is refusing to create a DIB for the 'empty' icon during the initial load phase. This is returning a null value, which is then used in later API calls that assert that the arguments are non-null.

Solution is:
1. If the DIB cannot be created by the operating system based on the icon description, return a nullptr.
2. If the 'createSharedCursor' call returns nullptr, fall back to the default icon case so that we have something that can be used during early layout until the load finishes.
Comment 1 Brent Fulgham 2015-01-13 20:30:07 PST 
Created attachment 244574 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-14 10:25:44 PST 
Comment on attachment 244574 [details]
Patch

Clearing flags on attachment: 244574

Committed r178424: <http://trac.webkit.org/changeset/178424>
Comment 3 WebKit Commit Bot 2015-01-14 10:25:47 PST 
All reviewed patches have been landed.  Closing bug.