Bug 140414 - Convert WebUserContentControllerProxy to an API::Object bridged to WKUserContentController
Summary: Convert WebUserContentControllerProxy to an API::Object bridged to WKUserCont...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on: 140429 140432
Blocks:
  Show dependency tree / graph
 
Reported: 2015-01-13 15:04 PST by Sam Weinig
Modified: 2015-01-18 18:04 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.91 KB, patch)
2015-01-13 15:06 PST, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2015-01-13 15:04:44 PST 
Convert WebUserContentControllerProxy to an API::Object bridged to WKUserContentController
Comment 1 Sam Weinig 2015-01-13 15:06:43 PST 
Created attachment 244552 [details]
Patch
Comment 2 Sam Weinig 2015-01-13 15:35:17 PST 
Committed r178385: <http://trac.webkit.org/changeset/178385>
Comment 3 Chris Dumez 2015-01-13 18:35:42 PST 
Seems to have broken GTK build:
Last 500 characters of output:
rocess/API/gtk/WebKitUserContentManager.cpp
../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp: In constructor '_WebKitUserContentManagerPrivate::_WebKitUserContentManagerPrivate()':
../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp:37:33: error: 'create' is not a member of 'WebKit::WebUserContentControllerProxy'
         : userContentController(WebUserContentControllerProxy::create())
                                 ^
ninja: build stopped: subcommand failed.
Comment 4 WebKit Commit Bot 2015-01-14 02:11:56 PST 
Re-opened since this is blocked by bug 140432