Bug 140405 - Should disable immediate actions for iTunes
Summary: Should disable immediate actions for iTunes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-13 13:47 PST by Beth Dakin
Modified: 2015-01-13 14:34 PST (History)
0 users

See Also:

Attachments
Patch (2.02 KB, patch)
2015-01-13 13:50 PST, Beth Dakin 		no flags Details | Formatted Diff | Diff
Patch (2.96 KB, patch)
2015-01-13 14:00 PST, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-01-13 13:47:49 PST 
Should disable immediate actions for iTunes

rdar://problem/19274499
Comment 1 Beth Dakin 2015-01-13 13:50:18 PST 
Created attachment 244541 [details]
Patch
Comment 2 Beth Dakin 2015-01-13 14:00:33 PST 
Created attachment 244543 [details]
Patch
Comment 3 Tim Horton 2015-01-13 14:09:53 PST 
Comment on attachment 244543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244543&action=review

> Source/WebKit/mac/WebView/WebImmediateActionController.mm:228
> +    if (customClientAnimationController == [NSNull null] || applicationIsITunes()) {

I think we should avoid doing all of this work and just not install the GR if we're in iTunes.
Comment 4 Beth Dakin 2015-01-13 14:34:30 PST 
(In reply to comment #3)
> Comment on attachment 244543 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244543&action=review
> 
> > Source/WebKit/mac/WebView/WebImmediateActionController.mm:228
> > +    if (customClientAnimationController == [NSNull null] || applicationIsITunes()) {
> 
> I think we should avoid doing all of this work and just not install the GR
> if we're in iTunes.

Tim and I talked about this in person. We went back and forth a few times, but ultimately decided to keep it as-is to match the SPI.

http://trac.webkit.org/changeset/178378