Bug 140395 - Move more of the Navigation infrastructure down to WebPageProxy
Summary: Move more of the Navigation infrastructure down to WebPageProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-13 11:21 PST by Sam Weinig
Modified: 2015-01-13 22:09 PST (History)
4 users (show)

See Also:


Attachments
Patch (81.79 KB, patch)
2015-01-13 11:27 PST, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2015-01-13 11:21:24 PST
Move more of the Navigation infrastructure down to WebPageProxy
Comment 1 Sam Weinig 2015-01-13 11:27:36 PST
Created attachment 244525 [details]
Patch
Comment 2 Sam Weinig 2015-01-13 14:22:24 PST
Committed r178375: <http://trac.webkit.org/changeset/178375>
Comment 3 Carlos Alberto Lopez Perez 2015-01-13 15:12:47 PST
(In reply to comment #2)
> Committed r178375: <http://trac.webkit.org/changeset/178375>

This broke the GTK build.

The breakage was reported by the GTK EWS.
Comment 4 Chris Dumez 2015-01-13 16:34:30 PST
iOS build fix landed in <https://trac.webkit.org/r178391>.
Comment 5 Chris Dumez 2015-01-13 17:30:22 PST
(In reply to comment #3)
> (In reply to comment #2)
> > Committed r178375: <http://trac.webkit.org/changeset/178375>
> 
> This broke the GTK build.
> 
> The breakage was reported by the GTK EWS.

Speculative GTK build fix landed in <http://trac.webkit.org/changeset/178395>.
Comment 6 Chris Dumez 2015-01-13 22:09:43 PST
(In reply to comment #5)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Committed r178375: <http://trac.webkit.org/changeset/178375>
> > 
> > This broke the GTK build.
> > 
> > The breakage was reported by the GTK EWS.
> 
> Speculative GTK build fix landed in
> <http://trac.webkit.org/changeset/178395>.

Second GTK build fix: <https://trac.webkit.org/r178408>.