Bug 140386 - Add generic Capture class for cross-thread lambda captures
Summary: Add generic Capture class for cross-thread lambda captures
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-13 01:40 PST by Zan Dobersek
Modified: 2016-08-29 11:25 PDT (History)
7 users (show)

See Also:


Attachments
Patch (57.27 KB, patch)
2015-01-13 03:05 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-mountainlion-wk2 (533.30 KB, application/zip)
2015-01-13 04:19 PST, Build Bot
no flags Details
WIP (58.71 KB, patch)
2015-01-21 09:01 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (914.66 KB, application/zip)
2015-01-21 10:23 PST, Build Bot
no flags Details
Archive of layout-test-results from ews100 for mac-mavericks (593.72 KB, application/zip)
2015-01-21 12:12 PST, Build Bot
no flags Details
WIP (60.62 KB, patch)
2015-01-25 00:00 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff
WIP (59.84 KB, patch)
2015-02-05 07:18 PST, Zan Dobersek
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-mavericks (535.59 KB, application/zip)
2015-02-05 08:30 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2015-01-13 01:40:38 PST
Add generic Capture class for cross-thread lambda captures
Comment 1 Zan Dobersek 2015-01-13 03:05:02 PST
Created attachment 244504 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-13 03:06:12 PST
Attachment 244504 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:227:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2015-01-13 04:19:19 PST
Comment on attachment 244504 [details]
Patch

Attachment 244504 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6240355376693248

New failing tests:
http/tests/xmlhttprequest/workers/methods-async.html
http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html
http/tests/xmlhttprequest/workers/methods.html
Comment 4 Build Bot 2015-01-13 04:19:22 PST
Created attachment 244506 [details]
Archive of layout-test-results from ews104 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Zan Dobersek 2015-01-21 09:01:10 PST
Created attachment 245064 [details]
WIP
Comment 6 WebKit Commit Bot 2015-01-21 09:04:30 PST
Attachment 245064 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:227:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Build Bot 2015-01-21 10:23:16 PST
Comment on attachment 245064 [details]
WIP

Attachment 245064 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6340507974238208

New failing tests:
http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html
Comment 8 Build Bot 2015-01-21 10:23:19 PST
Created attachment 245067 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 9 Build Bot 2015-01-21 12:12:18 PST
Comment on attachment 245064 [details]
WIP

Attachment 245064 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5556820458340352

New failing tests:
http/tests/xmlhttprequest/workers/methods-async.html
http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html
http/tests/xmlhttprequest/workers/methods.html
Comment 10 Build Bot 2015-01-21 12:12:22 PST
Created attachment 245076 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 11 Zan Dobersek 2015-01-25 00:00:14 PST
Created attachment 245295 [details]
WIP
Comment 12 WebKit Commit Bot 2015-01-25 00:23:11 PST
Attachment 245295 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:227:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Zan Dobersek 2015-02-05 07:18:07 PST
Created attachment 246099 [details]
WIP
Comment 14 WebKit Commit Bot 2015-02-05 07:20:55 PST
Attachment 246099 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:227:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 Build Bot 2015-02-05 08:30:12 PST
Comment on attachment 246099 [details]
WIP

Attachment 246099 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6618914465251328

New failing tests:
http/tests/xmlhttprequest/workers/methods-async.html
http/tests/xmlhttprequest/workers/methods.html
Comment 16 Build Bot 2015-02-05 08:30:17 PST
Created attachment 246102 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 17 Zan Dobersek 2016-08-29 11:25:37 PDT
C++14 now enables more efficient initialization of captured values.