Bug 140382 - Perf dashboard always assigns the result of A/B testing with build request 1
Summary: Perf dashboard always assigns the result of A/B testing with build request 1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-12 21:52 PST by Ryosuke Niwa
Modified: 2015-01-23 16:24 PST (History)
2 users (show)

See Also:

Attachments
Fixes the bug (3.32 KB, patch)
2015-01-12 22:00 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-01-12 21:52:45 PST 
There's a subtle bug in report-processor.php that results in all A/B testing results being associated with the build request with id=1.
Comment 1 Ryosuke Niwa 2015-01-12 22:00:29 PST 
Created attachment 244495 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2015-01-23 16:22:28 PST 
Thanks for the review!
Comment 3 Ryosuke Niwa 2015-01-23 16:24:27 PST 
Comment on attachment 244495 [details]
Fixes the bug

Clearing flags on attachment: 244495

Committed r179037: <http://trac.webkit.org/changeset/179037>
Comment 4 Ryosuke Niwa 2015-01-23 16:24:31 PST 
All reviewed patches have been landed.  Closing bug.