Bug 140370 - Make delegates conform to formal delegate protocols
Summary: Make delegates conform to formal delegate protocols
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-12 12:55 PST by Anders Carlsson
Modified: 2015-01-12 13:07 PST (History)
0 users

See Also:


Attachments
Patch (28.28 KB, patch)
2015-01-12 12:57 PST, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-01-12 12:55:25 PST
Make delegates conform to formal delegate protocols
Comment 1 Anders Carlsson 2015-01-12 12:57:31 PST
Created attachment 244459 [details]
Patch
Comment 2 mitz 2015-01-12 13:05:17 PST
Comment on attachment 244459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244459&action=review

> Tools/DumpRenderTree/mac/TestRunnerMac.mm:254
> +    return [(id)[[mainFrame webView] UIDelegate] numberOfPendingGeolocationPermissionRequests];

You should cast to UIDelegate * here.

> Tools/DumpRenderTree/mac/TestRunnerMac.mm:438
> +    [(id)[[mainFrame webView] UIDelegate] didSetMockGeolocationPermission];

And here.
Comment 3 Anders Carlsson 2015-01-12 13:07:57 PST
Committed r178293: <http://trac.webkit.org/changeset/178293>