Bug 140362 - build.webkit.org/dashboard should filter out commits to other branches
Summary: build.webkit.org/dashboard should filter out commits to other branches
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Keywords: InRadar
Depends on:
Reported: 2015-01-12 09:41 PST by Alexey Proskuryakov
Modified: 2016-01-22 23:04 PST (History)
5 users (show)

See Also:

proposed fix (14.40 KB, patch)
2015-02-22 22:08 PST, Alexey Proskuryakov
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-01-12 09:41:46 PST
It is misleading to have the dashboard say "XXX revisions behind" when these changes are on a different branch, or when they are on a tag.

We can use branch information from trac to do this. Even better, it may be possible to somehow get informed about ignored patches (e.g. patches that only touch ChangeLog, or patches for other files that are in a blacklist for the given platform).
Comment 1 Alexey Proskuryakov 2015-01-14 22:36:22 PST
Comment 2 Alexey Proskuryakov 2015-02-22 22:08:05 PST
Created attachment 247097 [details]
proposed fix
Comment 3 Tim Horton 2015-02-22 22:13:08 PST
Comment on attachment 247097 [details]
proposed fix

Comment 4 Alexey Proskuryakov 2015-02-23 09:43:09 PST
Committed <http://trac.webkit.org/r180504>.
Comment 5 Jason Marcell 2016-01-22 17:33:26 PST
Comment on attachment 247097 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=247097&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:244
> +

fromDate and toDate end up having the same value. Was this intentional?
Comment 6 Alexey Proskuryakov 2016-01-22 23:04:15 PST
I think so, it's supposed to download commits for that one day.