Bug 140356 - [EFL] Fix libseccomp dependency
Summary: [EFL] Fix libseccomp dependency
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-12 06:55 PST by Csaba Osztrogonác
Modified: 2015-01-12 07:09 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.24 KB, patch)
2015-01-12 06:56 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-01-12 06:55:15 PST
The problem is that building of many source files should 
depend on the generated include/seccomp.h , but they don't.

The bug is already fixed in libseccomp:
http://sourceforge.net/p/libseccomp/libseccomp/ci/3b6b69184196189d3b53ae695c0d130b9cf70784/

I propose adding this fix to jhbuild patches.

(note: It causes build error during cross compiling when 
generating of include/seccomp.h is very very slow. )

error log:
-----------
>> INFO: building in directory include/ ...
>> INFO: building in directory src/ ...
 GEN seccomp.h
In file included from api.c:32:0:
/home/webkit/WebKit/WebKitBuild/DependenciesEFL/Source/libseccomp-2.1.0/include/seccomp.h:407:1: error: unterminated comment
 /**
 ^
In file included from api.c:32:0:
...
Comment 1 Csaba Osztrogonác 2015-01-12 06:56:04 PST
Created attachment 244444 [details]
Patch
Comment 2 Michael Catanzaro 2015-01-12 07:00:03 PST
I would update to 2.1.1 (which should include that fix) instead of building from an older git snapshot.

You can copy the moduleset change from the very bottom of https://bugs.webkit.org/attachment.cgi?id=243959&action=prettypatch
Comment 3 Csaba Osztrogonác 2015-01-12 07:09:39 PST
(In reply to comment #2)
> I would update to 2.1.1 (which should include that fix) instead of building
> from an older git snapshot.
> 
> You can copy the moduleset change from the very bottom of
> https://bugs.webkit.org/attachment.cgi?id=243959&action=prettypatch

Good point, let's bump instead of cherry picking: bug140357